fix: testing environment config file ignored and needlessly wait for timeout#735
Open
mtorromeo wants to merge 2 commits intotemporalio:masterfrom
Open
fix: testing environment config file ignored and needlessly wait for timeout#735mtorromeo wants to merge 2 commits intotemporalio:masterfrom
mtorromeo wants to merge 2 commits intotemporalio:masterfrom
Conversation
|
@mtorromeo is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
|
|
mtorromeo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Changed
Temporal\Testing\Environment::startRoadRunnerto actually use the$configFileparameter and to not wait for timeout if the process is not running.Why?
In
Temporal\Testing\EnvironmentthestartRoadRunnerhas a$configFileparameter, which is also passed through thestartmethod's$roadRunnerConfigFileparameter but that is completely ignored.In
startRoadRunnerif the executed process crashes/exists before$commandTimeouttriggers (which is 10 seconds by default but could also be much longer) then the function will wait needlessly for the timeout while it could return right away.Checklist
Confirmed by testing it on my own project, also with a misconfigured command that does not start correctly.